Repository navigation
Conversation
Collaborator
Author
|
@altsybee : Please review this proposed change. |
sawenzel
force-pushed
the
o2-7335-firstorbitmc
branch
from
November 18, 2026 17:42
cf90493 to
035247f
Compare
This replaces the hardcoded list of MC productions in AggregatedRunInfo::adjust_from_MC by a per-run value from CCDB.
- The correction now uses the key FirstOrbitMC of the MCProdInfo object of each run.
- The shift is (FirstOrbitMC - orbitSOR) mod orbitsPerTF, so it holds for any TF length, anchor time and software version.
- Without the key, no correction is applied.
- The shift is computed by AggregatedRunInfo::tfAlignmentShift, covered by a unit test; an invalid orbitsPerTF disables it.
- MCProdInfo is read without a not-after limit, so corrections published later stay visible.
- New productions record FirstOrbitMC themselves (O2DPG). Existing ones are fixed with O2DPG's MC/prodinfo/mcprodinfo_firstorbit.py.
- Publishing needs the aliprod role. If a production needs fixing, please open an O2 JIRA ticket and ask Sandro Wenzel.
Recipe to fix a production:
mcprodinfo_firstorbit.py scan --tag <TAG> -o <TAG>.json
mcprodinfo_firstorbit.py rerun <TAG>.json --crosscheck 3
mcprodinfo_firstorbit.py apply <TAG>.json --comment "FirstOrbitMC added because of O2-XXXX" --yes
scan reads the first orbit of each run from its GRID job logs, rerun fills runs without logs and cross-checks a sample (needs CVMFS), apply publishes (dry run without --yes).
https://its.cern.ch/jira/browse/O2-7335
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
sawenzel
force-pushed
the
o2-7335-firstorbitmc
branch
from
November 18, 2026 17:52
035247f to
aeaece1
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces the hardcoded list of MC productions in
AggregatedRunInfo::adjust_from_MCby a per-run value from CCDB.The SOR correction for MC anchored with a ramp-up shift that is not a multiple of the TF length depends on the run, not on the production: on the TF length, on the ITS ramp-up at the anchor time, and on the O2DPG version that anchored it. The MCProdInfo object of each run now carries
FirstOrbitMC, the first orbit the MC actually used, and the shift is computed as (FirstOrbitMC-orbitSOR) modorbitsPerTF. Without the key, no correction is applied.The key has already been published for all 2210 runs with MC data of the productions in the list (EP26d1 is an event-pool production that is not analysed and has no MCProdInfo, so it needs none), read from the runs' own GRID job logs and cross-checked by rerunning the anchoring. For 78 of these runs the list on
devstill applies a wrong shift:To fix a production in the future, use
MC/prodinfo/mcprodinfo_firstorbit.pyfrom O2DPG (recipe in the commit message). Publishing needs the aliprod role, so please open an O2 JIRA ticket and ask me.Relates to https://its.cern.ch/jira/browse/O2-7335 and AliceO2Group/O2DPG#2558
Assisted by Claude Code.